Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comp: divider): add divider component #62

Merged
merged 1 commit into from
Dec 27, 2020
Merged

feat(comp: divider): add divider component #62

merged 1 commit into from
Dec 27, 2020

Conversation

LaamGinghong
Copy link
Contributor

link #32

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited
Loading

Codecov Report

Merging #62 (6590e94) into main (0c37aee) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   92.20%   92.54%   +0.34%     
==========================================
  Files          31       32       +1     
  Lines         372      389      +17     
  Branches       70       76       +6     
==========================================
+ Hits          343      360      +17     
  Misses         11       11              
  Partials       18       18
Impacted Files Coverage Δ
packages/components/core/config/useGlobalConfig.ts 100.00% <100.00%> (ø)
packages/components/divider/src/Divider.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c37aee...6590e94. Read the comment docs.

@LaamGinghong
Copy link
Contributor Author

@danranVm 麻烦安排review

danranVm
danranVm requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@danranVm danranVm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

样式部分没有太仔细看，可以先这样提交，后续再重构样式。

packages/components/divider/docs/index.zh.md Outdated Show resolved Hide resolved
packages/components/divider/src/Divider.vue Show resolved Hide resolved
packages/components/divider/src/Divider.vue Outdated Show resolved Hide resolved
packages/components/divider/src/Divider.vue Outdated Show resolved Hide resolved
@danranVm danranVm requested review from huangtenghui and removed request for ssccchh December 23, 2020 07:57
@danranVm
Copy link
Member

经过我们其他的几个 reviewer 的讨论，建议去掉 position 的 string 类型，只支持 left center right

十分抱歉，:cry:

danranVm
danranVm approved these changes Dec 23, 2020
View reviewed changes
packages/components/divider/demo/with-text.md Outdated Show resolved Hide resolved
packages/components/divider/demo/with-text.md Outdated Show resolved Hide resolved
packages/components/divider/docs/index.zh.md Outdated Show resolved Hide resolved
packages/components/divider/docs/index.zh.md Outdated Show resolved Hide resolved
@LaamGinghong
Copy link
Contributor Author

@danranVm @Pupils-web 麻烦重新review

@danranVm
Copy link
Member

@LaamGinghong 感谢你的 PR, LGTM

@danranVm danranVm merged commit c76f420 into IDuxFE:main Dec 27, 2020
@LaamGinghong LaamGinghong deleted the feature/divider branch December 27, 2020 08:21
@danranVm danranVm mentioned this pull request Dec 27, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danranVm danranVm danranVm approved these changes

@huangtenghui huangtenghui Awaiting requested review from huangtenghui

@ssccchh ssccchh Awaiting requested review from ssccchh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaamGinghong @danranVm @ssccchh