-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp: divider): add divider component #62
Conversation
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 92.20% 92.54% +0.34%
==========================================
Files 31 32 +1
Lines 372 389 +17
Branches 70 76 +6
==========================================
+ Hits 343 360 +17
Misses 11 11
Partials 18 18
Continue to review full report at Codecov.
|
4a239ea
to
48a1895
Compare
@danranVm 麻烦安排review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
样式部分没有太仔细看,可以先这样提交,后续再重构样式。
经过我们其他的几个 reviewer 的讨论,建议去掉 十分抱歉,:cry: |
5af825d
to
ce30986
Compare
@danranVm @Pupils-web 麻烦重新review |
e1fbe82
to
6590e94
Compare
@LaamGinghong 感谢你的 PR, LGTM |
link #32
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information